Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fix failing test cases: Soft-deprecate ModelV2.from_batch (in favor of ModelV2.__call__). #19693

Merged
merged 3 commits into from
Oct 25, 2021
Merged

[RLlib] Fix failing test cases: Soft-deprecate ModelV2.from_batch (in favor of ModelV2.__call__). #19693

merged 3 commits into from
Oct 25, 2021

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Oct 25, 2021 •
edited
Loading

Fix failing test cases: Soft-deprecate ModelV2.from_batch (in favor of ModelV2.call).

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

krfricke
krfricke approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp

@sven1977 sven1977 requested review from krfricke and removed request for gjoliver October 25, 2021 12:43
@sven1977 sven1977 assigned krfricke and unassigned gjoliver Oct 25, 2021
@sven1977 sven1977 merged commit b213565 into ray-project:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sven1977 @krfricke @gjoliver